Skip to content

Conversation

@yotamofek
Copy link
Contributor

also, remove outdated FIXME, and simplify bespoke toml parsing

Might improve tidy's memory consumption by a tiny bit 😅

also, remove outdated FIXME, and simplify bespoke toml parsing
@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kobzol
Copy link
Member

Kobzol commented Oct 20, 2025

I found the previous version to be easier to read/understand, tbh. And read_to_string should be fine here.

@yotamofek
Copy link
Contributor Author

That's reasonable :)
So closing this. Thanks for taking a look!

@yotamofek yotamofek closed this Oct 20, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2025
@yotamofek yotamofek deleted the pr/tidy/extdeps-cleanup branch October 21, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants