compiletest: More directive handling tweaks #147934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that all directive names are checked against a list of known-good names, these ad-hoc checks can never fire.
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-testsuite
Zalathar
changed the title
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Oct 21, 2025
Rollup merge of #147934 - Zalathar:directive, r=jieyouxu compiletest: More directive handling tweaks - Follow-up to #147903. --- These are some more preparatory changes that were extracted from a larger overhaul of directive handling that I'm still working on. --- The revision check was introduced by #61778, and later modified by #113603. It doesn't appear to be doing anything particularly load-bearing (since a bogus mode seems to cause a panic later anyway), and getting rid of it avoids the need to pass the current test revision to directive-handling code. - #61778 - #113603 r? jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestProps#147903.These are some more preparatory changes that were extracted from a larger overhaul of directive handling that I'm still working on.
The revision check was introduced by #61778, and later modified by #113603. It doesn't appear to be doing anything particularly load-bearing (since a bogus mode seems to cause a panic later anyway), and getting rid of it avoids the need to pass the current test revision to directive-handling code.
// {check,build,run}-passpass modes #61778r? jieyouxu