Port cfg!() macro to the new attribute parsing system
#147945
Conversation
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
rustbot
added
A-attributes
| | ^^^^^---^ | ||
| | | | | ||
| | | expected a valid identifier here | ||
| | help: must be of the form: `#![cfg(predicate)]` |
There was a problem hiding this comment.
This help message is suggesting attribute related things, which is awful. Will fix in a separate PR that will go before this one (which is why this is in draft)
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
JonathanBrouwer
force-pushed
the
cfg_macro
branch
from
e4bea66 to
58efee4
Compare
JonathanBrouwer
added
the
S-blocked
| &CFG_ATTR_TEMPLATE, | ||
| ) | ||
| .ok_or_else(|| { | ||
| .map_err(|_err: ErrorGuaranteed| { |
There was a problem hiding this comment.
Is the delayed bug below necessary? Having an error guaranteed here effectively proves error emission already
There was a problem hiding this comment.
Because this is in a Parser run, we need to produce PResult, which is Result<T, Diag>. This was my hack to create a Diag, I was still gonna see if there was a better way to do this
| cfg!(); //~ ERROR macro requires a cfg-pattern | ||
| cfg!(123); //~ ERROR literal in `cfg` predicate value must be a boolean | ||
| cfg!(foo = 123); //~ ERROR literal in `cfg` predicate value must be a string | ||
| cfg!(123); //~ ERROR malformed `cfg` attribute input |
There was a problem hiding this comment.
I'm not sure I like these diagnostics, it's not an attribute!
There was a problem hiding this comment.
There is already a discussion open for this, that's why it's a draft :)
|
|
||
| Erroneous code example: | ||
|
|
||
| ```compile_fail,E0536 |
There was a problem hiding this comment.
Maybe this old error code was correct
There was a problem hiding this comment.
The old error code (E0536) is no longer emitted by anything, except cfg in the doc attribute. This example now emits the new error code.
I may change the example to use the doc attribute for now
4 participants
r? @jdonszelmann