Use fstatat() in DirEntry::metadata on Apple platforms #147986
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple supports
fstatat
on macOS >=10.10 (source), and according to Platform Support the oldest supported version is 10.12.Google says iOS >=10 supports
fstatat
but doesn't provide a source. *-apple-ios says the minimum supported iOS version is 10.0.Unsure about tvOS, watchOS and visionOS, hoping CI can confirm this.
I am testing with fastdu which is effectively a stress test for
DirEntry::metadata
. In one test this provides a 1.13x speedup.You can also reproduce a speedup with a program like this (providing a directory with many entries):