Revert constification of AsRef for Cow due to inference failure
#148011
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
clarfonthey
force-pushed
the
const-convert-revert
branch
from
b3c408e to
cb7fb35
Compare
clarfonthey
changed the title
AsRef constificationAsRef for Cow due to inference failure
bors
added
S-waiting-on-bors
theemathas
added
the
beta-nominated
rustbot
added
the
beta-accepted
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 23, 2025
…, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: rust-lang#147964 Original PR: rust-lang#145279 Previous revert: rust-lang#148011 `const Borrow`/`Deref` tracking issue: rust-lang#143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 24, 2025
…, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: rust-lang#147964 Original PR: rust-lang#145279 Previous revert: rust-lang#148011 `const Borrow`/`Deref` tracking issue: rust-lang#143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 24, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#134316 (Add `String::replace_first` and `String::replace_last`) - rust-lang/rust#147713 (Retire ast::TyAliasWhereClauses.) - rust-lang/rust#148011 (Revert constification of `AsRef for Cow` due to inference failure ) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 24, 2025
Rollup merge of #148016 - clarfonthey:const-convert-revert-2, r=cuviper Revert constification of `Borrow` and `Deref for Cow` due to inference failure Reported issue: #147964 Original PR: #145279 Previous revert: #148011 `const Borrow`/`Deref` tracking issue: #143773 Should have additional crater run to verify this fixes the issue. Since other PR is in the queue, this will need to be rebased after that merges. Also will want a beta nomination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported issue: #147964
Original PR: #145279
const AsReftracking issue: #143773Should have additional crater run to verify this fixes the issue.