1.91.0 release notes #148013
1.91.0 release notes #148013
Conversation
rustbot
added
S-waiting-on-review
|
Hi relnotes-interest-group, this issue/PR could use some help in reviewing / cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross |
| - [Trait impl modifiers (e.g., `unsafe`, `!`, `default`) in inherent impls are no longer syntactically valid](https://github.com/rust-lang/rust/pull/144386) | ||
| - [Start reporting future breakage for `ILL_FORMED_ATTRIBUTE_INPUT` in dependencies](https://github.com/rust-lang/rust/pull/144544) | ||
| - [Be more strict when parsing attributes, erroring on many invalid attributes](https://github.com/rust-lang/rust/pull/144689) | ||
| - [fix drop scope for `super let` bindings within `if let`](https://github.com/rust-lang/rust/pull/145342) |
There was a problem hiding this comment.
There's a wording suggestion at #146002 (comment)
| ([build cache doc](https://doc.rust-lang.org/nightly/cargo/reference/build-cache.html)) | ||
| [#15833](https://github.com/rust-lang/cargo/pull/15833) | ||
| [#15840](https://github.com/rust-lang/cargo/pull/15840) | ||
| - 🎉 Stabilize `build.build-dir`. |
There was a problem hiding this comment.
This seems to be a duplicate
| Compiler | ||
| -------- | ||
|
|
||
| - [Error on invalid `#[link]` attributes](https://github.com/rust-lang/rust/pull/143193) |
There was a problem hiding this comment.
The #[link] attribute is in this section while #[should_panic] is in the compatibility notes. Feels to me like this should be moved to compatibility notes
| - [Lower pattern bindings in the order they're written and base drop order on primary bindings' order](https://github.com/rust-lang/rust/pull/143764) | ||
| - [Stabilize declaration of c-style variadic functions for sysv64, win64, efiapi, and aapcs ABIs](https://github.com/rust-lang/rust/pull/144066). | ||
| This brings these ABIs in line with the C ABI: variadic functions can be declared in extern blocks but not defined. | ||
| - [Always require coroutine captures to be drop-live](https://github.com/rust-lang/rust/pull/144156) |
There was a problem hiding this comment.
maybe move this down to Compatability notes?
Not a language feature (or something we expect people to encounter much), just a bug fix which allows strictly less code to compile
| when `build.build-dir` is set. These tarballs were previously included due to | ||
| an oversight and are now treated as intermediate artifacts. | ||
| To get `.crate` tarballs as final artifacts, use `cargo package`. | ||
| In the next version, this change will apply regardless of `build.build-dir`. |
There was a problem hiding this comment.
We should update https://doc.rust-lang.org/nightly/cargo/CHANGELOG.html#changed-1 in that case. I'll try to file a PR there too, though it probably won't make it in time for the release.
| To get `.crate` tarballs as final artifacts, use `cargo package`. | ||
| In the next version, this change will apply regardless of `build.build-dir`. | ||
| [#15910](https://github.com/rust-lang/cargo/pull/15910) | ||
| - Adjust Cargo messages to match rustc diagnostic style. |
There was a problem hiding this comment.
Why is this a compatibility note?
There was a problem hiding this comment.
Per discussion on Zulip (I think you were in the thread), this may cause people to want to alter their editor/terminal's color schemes. I definitely did.
I'm open to dropping it or moving it to the Cargo section, but that's my rationale.
| Cargo | ||
| ----- | ||
|
|
||
| - 🎉 Stabilize `build.build-dir`. |
There was a problem hiding this comment.
Should we add a compatibility note that using this feature may break some build scripts, tools, and tests that rely on internals of cargo and that we may do further changes of these internals in a future release (rust-lang/cargo#15010)?
There was a problem hiding this comment.
Happy to include something, especially if you can propose some text!
8 participants
This imports #147010 into a PR in preparation for the release next week. It also imports a subset of the Cargo release notes (cc @rust-lang/cargo).
r? @rust-lang/release
@TriageBot ping relnotes-interest-group