Handle OOM when writing to Vec
#148024
Open
Handle OOM when writing to Vec
#148024
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
|
Seems similar to #84612 Cc @kornelski |
hkBst
suggested changes
Oct 23, 2025
| where | ||
| A: Allocator, | ||
| { | ||
| debug_assert!(vec.capacity() >= pos + buf.len()); |
There was a problem hiding this comment.
Suggested change
| debug_assert!(pos <= vec.len()); | |
| debug_assert!(buf.len() <= vec.capacity() - pos); |
This adds a debug check, and is not dependent on maximum size of allocations to prevent overflow.
| { | ||
| // For safety reasons, we don't want this sum to overflow ever. | ||
| // If this saturates, the reserve should panic to avoid any unsound writing. | ||
| // If this saturates, the reserve should fail to avoid any unsound writing. |
There was a problem hiding this comment.
This now reads badly. Perhaps:
Suggested change
| // If this saturates, the reserve should fail to avoid any unsound writing. | |
| // To avoid unsound writing, if this saturates the reserve should fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't found any discussion on this, but I think that handling those OOM is desirable.