experimental shipping of more CMake files for Enzyme #148027
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
dist-more-cmake
branch
from
9766ed8 to
d6a5474
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
dist-more-cmake
branch
from
d6a5474 to
b2afe07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing I just added the whole cmake folder for now, we might want to reduce it just to the LLVMconfig.cmake file later.
Based on some local comparisons between a
x.py dist rust-devfolder structure and the ci-llvm folder structure (and where enzyme is looking) I think this should end up at the right location.What would be the best way without merging to test that locally or in CI to verify that Enzyme now works?
Do a local x.py dist rust-dev build
Build rust+enzyme with download-ci-llvm, wait till it fails.
Delete the ci-llvm folder and replace it with the component from 1., which now includes the cmake files?
r? @Kobzol