rustc_codegen_llvm: Add debug locations to write_operand_repeatedly()
#148058
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
Enselic
force-pushed
the
write_operand_repeatedly-dbg-loc
branch
2 times, most recently
from
934c3af to
4b7b021
Compare
This comment has been minimized.
This comment has been minimized.
So that stepping with a debugger over lines such as:
let h = ["whatever"; 8];
works.
Use the same technique as we already do in `cfi_type_test()`.
Since all emitted LLVM instructions are looped over, a debugger will
unfortunately step as many times as we repeat. Not sure how to solve
that. It can become quite annoying if you have say `1024` repetitions.
Enselic
force-pushed
the
write_operand_repeatedly-dbg-loc
branch
from
4b7b021 to
79c8c8a
Compare
Enselic
changed the title
write_operand_repeatedly()write_operand_repeatedly()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that stepping with a debugger over lines such as:
works.
Use the same technique as we already do in
cfi_type_test().Since all emitted LLVM instructions are looped over, a debugger will unfortunately step as many times as we repeat. Not sure how to solve that. It can become quite annoying if you have say
1024repetitions.This is an alternative to #147462.