remove a performance hack

[lcnr]

This hack seems no longer used 🤔 nalgebra compiles without it.

Let's run perf to see whether it matters.

r? @BoxyUwU

[lcnr]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: d0ec043 (d0ec0432882a887ead13187076de6eae17b64240, parent: 8aab621cd56bdc704f73c9d9aaa9f35ab5ee55b0)

[rust-timer]

Finished benchmarking commit (d0ec043): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.1%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	2.9%	[2.1%, 3.3%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.14s -> 475.927s (0.17%)
Artifact size: 390.49 MiB -> 390.48 MiB (-0.00%)

[lcnr]

looks irrelevant for the new solver and I don't want perf opts in the trait solver if we don't have a test where they matter.

The last beta cutoff was yesterday, so we have a whole 12 weeks before this hits stable in case something does rely on its use in coherence. If so, I want to get another test for it.

[BoxyUwU]

@bors r+

tying random stuff to the recursion limit is always fun

[bors]

📌 Commit 561e3ce has been approved by BoxyUwU

It is now in the queue for this repository.

[bors]

⌛ Testing commit 561e3ce with merge cc63a0a...

[bors]

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing cc63a0a to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 34f954f (parent) -> cc63a0a (this PR)

Test differences

Show 1 test diff

1 doctest diff were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cc63a0abde59a0de58ced46a2a882364f967632c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. aarch64-apple: 6746.9s -> 8557.5s (26.8%)
2. pr-check-1: 1455.0s -> 1681.7s (15.6%)
3. aarch64-gnu-llvm-20-1: 3304.0s -> 3765.6s (14.0%)
4. x86_64-gnu-tools: 3312.0s -> 3762.0s (13.6%)
5. dist-aarch64-apple: 6482.8s -> 5726.1s (-11.7%)
6. x86_64-msvc-ext1: 6894.3s -> 7673.6s (11.3%)
7. aarch64-gnu-debug: 3771.6s -> 4175.0s (10.7%)
8. dist-aarch64-msvc: 5340.1s -> 5874.3s (10.0%)
9. dist-x86_64-apple: 7104.3s -> 6423.4s (-9.6%)
10. arm-android: 5507.4s -> 6008.5s (9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (cc63a0a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.237s -> 475.029s (-0.04%)
Artifact size: 390.52 MiB -> 390.46 MiB (-0.01%)