Migrate unused-revision-names check from tidy to compiletest #148078
+125
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what i understand, we need to migrate the check such that it executes before running the actual tests(revisions) as the runtest::run() assumes that theres no revision/unused-revision related issue.
Implementation/Logic:
(I initially thought to implement it in TestProps then execute it in runtest::run() but that would be too late).
Tests:
I've tried to keep its functioning as close to what it was in tidy as possible.
I'm not super sure if this is most optimal solution,
so any feedback on approach or potential edge cases would be very helpful.
Issue: #144671