Skip to content

Conversation

@nilotpal-n7
Copy link

@nilotpal-n7 nilotpal-n7 commented Oct 24, 2025

From what i understand, we need to migrate the check such that it executes before running the actual tests(revisions) as the runtest::run() assumes that theres no revision/unused-revision related issue.

Implementation/Logic:

  1. Declared unused_revision_names in EarlyProps.
  2. Parse unused_revision_names along side revisions in lib::make_test().
  3. Check unknown/unused revision before returning the final collected test in lib::make_test()

(I initially thought to implement it in TestProps then execute it in runtest::run() but that would be too late).

Tests:

  1. (./x test, saved the logs in a file, then grep the panic message) -> no error/panic found(related to this) -> means previous implementations passed.
  2. (I tested it using intentional errors like; same revision in //@ revision and //@ unused-revision-names, unknown revision, and the wildcard "") -> emits corrects panic/error messages and skips all check for "" -> correct output

I've tried to keep its functioning as close to what it was in tidy as possible.

I'm not super sure if this is most optimal solution,
so any feedback on approach or potential edge cases would be very helpful.


Issue: #144671

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2025

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2025
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot
Copy link
Collaborator

rustbot commented Oct 24, 2025

⚠️ Warning ⚠️

@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants