Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Oct 26, 2025

This PR adds a coverage scope (for -Zremap-path-scope) for controlling if the paths that ends up in code coverage output should be remapped or not.

Currently code coverage use the macro scope which is not a appropriate scope for them.

Found during the stabilization of -Zremap-path-scope #147611 (comment) and was asked to be in a separate PR in #147611 (comment).

r? compiler

@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2025

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in coverage tests.

cc @Zalathar

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 26, 2025
@lcnr
Copy link
Contributor

lcnr commented Oct 27, 2025

r? compiler

@rustbot rustbot assigned jieyouxu and unassigned lcnr Oct 27, 2025
@Zalathar
Copy link
Contributor

r=me after nits.

@Urgau Urgau force-pushed the add-coverage-scope branch from 13a8b6c to 94c893e Compare October 27, 2025 11:55
@jieyouxu jieyouxu assigned Zalathar and unassigned jieyouxu Oct 27, 2025
@Urgau
Copy link
Member Author

Urgau commented Oct 27, 2025

@bors r=Zalatha rollup

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

📌 Commit 94c893e has been approved by Zalatha

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 27, 2025
Add `coverage` scope for controlling paths in code coverage

This PR adds a `coverage` scope (for `-Zremap-path-scope`) for controlling if the paths that ends up in code coverage output should be remapped or not.

Currently code coverage use the `macro` scope which is not a appropriate scope for them.

Found during the stabilization of `-Zremap-path-scope` rust-lang#147611 (comment) and was asked to be in a separate PR in rust-lang#147611 (comment).

r? compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants