Skip to content

Improve bootstrap import error handling and warning clarity #148147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Improve bootstrap import error handling and warning clarity #148147

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c36a7f
Refine Python version checks and error messages
politikl Oct 25, 2025
5e0931f
Improve bootstrap import error handling and warning clarity
politikl Oct 25, 2025
fc00f6e
Merge pull request #1 from politikl/improve-bootstrap-errors
politikl Oct 26, 2025
9d1b1b6
Fix Python 2.7 compatibility: replace f-strings with .format()
politikl Oct 26, 2025
f2b8eb5
Fix Python formatting to match ruff style
politikl Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions x.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@
# Some systems don't have `python3` in their PATH. This isn't supported by x.py directly;
# they should use `x` or `x.ps1` instead.

# This file is only a "symlink" to bootstrap.py, all logic should go there.
# This file is only a "symlink" to bootstrap.py; all logic should go there.

# Parts of `bootstrap.py` use the `multiprocessing` module, so this entry point
# must use the normal `if __name__ == '__main__':` convention to avoid problems.

if __name__ == "__main__":
import os
import sys
Expand All @@ -29,7 +30,7 @@
# Python 3 isn't available, fall back to python 2
pass

# soft deprecation of old python versions
# Soft deprecation of old python versions
skip_check = os.environ.get("RUST_IGNORE_OLD_PYTHON") == "1"
if not skip_check and (major < 3 or (major == 3 and minor < 6)):
msg = cleandoc(
Expand All @@ -40,14 +41,25 @@
please file an issue to help us understand timelines.

This message can be suppressed by setting `RUST_IGNORE_OLD_PYTHON=1`
""".format(major, minor)
""".format(major, minor)
)
warnings.warn(msg, stacklevel=1)
warnings.warn(msg, stacklevel=2)

rust_dir = os.path.dirname(os.path.abspath(__file__))
bootstrap_path = os.path.join(rust_dir, "src", "bootstrap")

# Ensure bootstrap directory exists for clearer errors
if not os.path.isdir(bootstrap_path):
sys.exit(
"Error: expected bootstrap directory not found at {}".format(bootstrap_path)
)

# For the import below, have Python search in src/bootstrap first.
sys.path.insert(0, os.path.join(rust_dir, "src", "bootstrap"))
sys.path.insert(0, bootstrap_path)

import bootstrap
try:
import bootstrap
except ImportError as e:
sys.exit("Error importing bootstrap module: {}".format(e))

bootstrap.main()
Loading