Skip to content

fix: from FIXME(#24570) added more info #148156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: from FIXME(#24570) added more info #148156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68ab2c1
fix: from implementation of debug for file, added more info
WrldEngine Oct 26, 2025
98a7209
chore: change docs url language path
WrldEngine Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion library/std/src/sys/fs/windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1022,12 +1022,25 @@ impl FromRawHandle for File {

impl fmt::Debug for File {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
// FIXME(#24570): add more info here (e.g., mode)
let mut b = f.debug_struct("File");
b.field("handle", &self.handle.as_raw_handle());
if let Ok(path) = get_path(self) {
b.field("path", &path);
}

if let Ok(file_attr) = self.file_attr() {
b.field("read", &true);
if file_attr.perm().readonly() {
b.field("write", &false);
} else {
b.field("write", &true);
}

// Getting analogue of file mode (unix) using file attributes
// See https://learn.microsoft.com/windows/win32/fileio/file-attribute-constants
b.field("attrs", &file_attr.attributes);
}

b.finish()
}
}
Expand Down
Loading