split definition and use site hidden tys #148170
Open
+187
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in exhaustiveness checking cc @Nadrieril |
rustbot
added
S-waiting-on-review
lcnr
commented
Oct 27, 2025
Comment on lines
-553
to
-555
| for hidden_ty in fcx_typeck_results.hidden_types.values() { | ||
| assert!(!hidden_ty.has_infer()); | ||
| } |
There was a problem hiding this comment.
ideally this is just an assert in EarlyBinder::bind. Adding that is more annoying than I expected as we need to do some lifetime dependent shit in some of the query system stuff which relies on transmutes. nm, actually just gonna do that in this PR as well
There was a problem hiding this comment.
also ass because we create ty::EarlyBinder<'tcx, impl IntoIterator<Item = ty::Binder<'tcx, ty::TraitRef<'tcx>>>> sometimes. An early binder of an iterator :x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking this implicitly is kinda messy and easy to get wrong.
r? @BoxyUwU