Allow codegen backends to indicate which crate types they support #148177
+62
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only --crate-type would be taken into account, not #![crate_type].
|
Some changes occurred in compiler/rustc_codegen_ssa |
rustbot
added
S-waiting-on-review
|
By the way I noticed that if you specify a crate type on the cli and this crate type is not supported by either the target or (with this PR) codegen backend, the crate will be treated as a library, but |
This way cargo will drop the unsupported crate types for crates that specify multiple crate types.
bjorn3
force-pushed
the
codegen_backend_crate_types
branch
from
4059118 to
b443a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way cargo will drop the unsupported crate types for crates that
specify multiple crate types.
This is a prerequisite for rust-lang/miri#4648.