rustdoc: remove --emit=unversioned-shared-resources
#148180
Open
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
rustbot has assigned @GuillaumeGomez. Use |
This option hasn't done anything for a long time, and can be removed. I've kept a shim in place to avoid breaking docs.rs, but the option no longer does anything. Using git-blame, I tracked this option down to f77ebd4, the commit that introduced EmitType in the first place. It was used with SharedResource::Unversioned, which no longer exists since f9e1f6f removed them. CC rust-lang#146220 Part of rust-lang#83784
notriddle
force-pushed
the
unversioned-shared-resources
branch
from
f3ebb35 to
87c8068
Compare
weihanglo
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Not on t-rustdoc but I did pretty much the same investigation in #146220, and got the same result as Michael's.
Thanks for this!
| for kind in list.split(',') { | ||
| if kind == "unversioned-shared-resources" { | ||
| if !nightly_options::is_unstable_enabled(matches) { | ||
| // Remove this as soon as docs.rs stops using it. |
There was a problem hiding this comment.
Maybe first remove it from docs.rs? Like that we don't need to keep it around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option hasn't done anything for a long time, and can be removed. I've kept a shim in place to avoid breaking docs.rs, but the option no longer does anything.
Using git-blame, I tracked this option down to
f77ebd4, the commit that introduced EmitType in the first place. It was used with SharedResource::Unversioned, which no longer exists since f9e1f6f removed them.
CC #146220
Part of #83784