Skip to content

Conversation

@moatom
Copy link
Contributor

@moatom moatom commented Oct 28, 2025

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2025
@rust-log-analyzer

This comment has been minimized.

[c.0, c.1].into_iter().collect::<TokenStream>()
}
};
(&&) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You almost certainly don't need to modify the minimal_quote_* macros. Those are only used internally in the implementation of quote! to produce the output code, not to parse the user input.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
fmt: checked 6508 files
tidy check
tidy [rustdoc_json (src)]: `rustdoc-json-types` modified, checking format version
tidy: Skipping binary file check, read-only filesystem
tidy [style (library)]: /checkout/library/proc_macro/src/quote.rs:592: Instead of XXX use FIXME
tidy [style (library)]: /checkout/library/proc_macro/src/quote.rs:593: Instead of XXX use FIXME
tidy [style (library)]: /checkout/library/proc_macro/src/quote.rs:607: Instead of XXX use FIXME
tidy [style (library)]: /checkout/library/proc_macro/src/quote.rs:629: Instead of XXX use FIXME
tidy [style (library)]: FAIL
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (25.2)
Collecting pip
---
checking C++ file formatting
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
error: `Gruop` should be `Group`
    ╭▸ library/proc_macro/src/quote.rs:563:33
    │
563 │     // sep内の$-GROUPに*が結合する場合は、このGruopは単なるTokenStreamとして扱う。(after_dollar=falseとして処理なので、再呼び出しで…
    ╰╴                                              ━━━━━
error: `Gruop` should be `Group`
    ╭▸ library/proc_macro/src/quote.rs:564:20
    │
564 │     // そうではない場合は、このGruopはrepで処理する。
    ╰╴                               ━━━━━
error: `AUTHORATIVE` should be `AUTHORITATIVE`
    ╭▸ library/proc_macro/src/quote.rs:592:76
    │
592 │                 // sep_opt = Some(minimal_quote_ts!(t).into()); // XXX TOO AUTHORATIVE
    ╰╴                                                                           ━━━━━━━━━━━
error: `AUTHORATIVE` should be `AUTHORITATIVE`
    ╭▸ library/proc_macro/src/quote.rs:593:80
    │
593 │ …     // sep_opt = Some(minimal_quote_ts!((@ t)).into()); // XXX TOO AUTHORATIVE SEP内の再帰的解決は後ほど。decl_macroに通して検査し…
    ╰╴                                                                     ━━━━━━━━━━━
rerun tidy with `--extra-checks=spellcheck --bless` to fix typos
tidy [extra_checks]: checks with external tool 'typos' failed
tidy [extra_checks]: FAIL
tidy: The following checks failed: extra_checks, style (library)
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1280:29

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:02:32
  local time: Tue Oct 28 16:02:40 UTC 2025
  network time: Tue, 28 Oct 2025 16:02:40 GMT
##[error]Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants