Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 28, 2025

Fixes #148184.

Problem was that in case an element inside the expansion's "original" element was not closed, this element would get its pending_exit field set to true, removing it when the next non-mergeable item gets pushed instead of being put inside it, and then next exit_elem would try to exit an empty class queue.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

Copy link
Member

@fmease fmease Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Currently reading through PR #146992 commit by commit to catch up.)

Quick side note: ElementStack ClassStack is not actually a stack, it's a tree!

Reading through this for the first time that's a bit confusing (moreso the resulting method names like enter_stack don't help me form an intuition (granted, it's 2AM for me rn and I'm only skimming the code) (was renamed in a later commit)).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it used to be a tree, it's now a stack (always one child). :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: exit_elem called on empty class stack

4 participants