bootstrap: PathSet::check only considers starts_with for --skip flag
#148223
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
… flag The original motivation for adding this `path.starts_with` check was to allow things like `--skip=src/etc`. But it affects quite a lot more things than just `--skip`; bootstrap is really not designed for the case when multiple Steps match the same filter. For example, `x test src` does ... something! Not sure what, but something! Change `starts_with` to only affect `--skip`, not anything else. The original motivation for this was to make it so that `x doc src/doc --open` doesn't open a dozen different books, but I expect it to fix various other steps in bootstrap as well.
jyn514
force-pushed
the
bootstrap-skip
branch
from
f27a772 to
0821573
Compare
|
the failure is because the I've added a manual As an aside, I'm not sure the snapshot test is testing what it intends to ... I don't think it realizes that the stage 2 compiler is only built as a dependency of the codegen backends. |
rustbot
added
the
A-testsuite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original motivation for adding this
path.starts_withcheck was to allow things like--skip=src/etc: #133492. But it affects quite a lot more things than just--skip; bootstrap is really not designed for the case when multiple Steps match the same filter (#134919 (comment)). For example,x test srcdoes ... something! Not sure what, but something!This has already caused several issues; see #135022, #135022, probably others I am forgetting.
Change
starts_withto only affect--skip, not anything else.The immediate motivation for this change was to prevent
x doc --open src/docfrom opening a dozen different pages (seewas_explicitly_invokedfor how this is related).r? bootstrap cc @marcoieni @onur-ozkan @jieyouxu @Zalathar