Skip to content

Unpin libc and rustix in compiler and rustbook #148263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Unpin libc and rustix in compiler and rustbook #148263

wants to merge 1 commit into from
+19 −23

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Oct 29, 2025 •
edited by rustbot
Loading

Closes #147501

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@clubby789
Copy link
Contributor Author

@bors try jobs=dist-loongarch64-musl

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 29, 2025
@rust-bors
Auto merge of #148263 - clubby789:bump-libc, r=<try>
e94ecf0 
Unpin `libc` in `compiler` and `rustbook`

try-job: dist-loongarch64-musl
@rust-bors
Copy link

rust-bors bot commented Oct 29, 2025

💔 Test for e94ecf0 failed: CI

@clubby789
Copy link
Contributor Author

I think GHA is back?
@bors try jobs=dist-loongarch64-musl

rust-bors bot added a commit that referenced this pull request Oct 29, 2025
@rust-bors
Auto merge of #148263 - clubby789:bump-libc, r=<try>
afcab83 
Unpin `libc` in `compiler` and `rustbook`

try-job: dist-loongarch64-musl
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 29, 2025

💔 Test for afcab83 failed: CI. Failed jobs:

@ehuss
Copy link
Contributor

ehuss commented Oct 29, 2025

I think you need to also update rustix to latest (1.1.2)

@clubby789
Copy link
Contributor Author

@bors try jobs=dist-loongarch64-musl

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 30, 2025
@rust-bors
Auto merge of #148263 - clubby789:bump-libc, r=<try>
c45feb0 
Unpin `libc` in `compiler` and `rustbook`

try-job: dist-loongarch64-musl
@rust-bors
Copy link

rust-bors bot commented Oct 30, 2025

☀️ Try build successful (CI)
Build commit: c45feb0 (c45feb0dc6f217612f4c7015978b67616cf17ebb, parent: 72fe2ffb391f397efdfafb2216028ed9952e8078)

@clubby789 clubby789 changed the title Unpin libc in compiler and rustbook Unpin libc and rustix in compiler and rustbook Oct 31, 2025
@clubby789
Copy link
Contributor Author

Looks like the issue is fixed 🙂

ehuss
ehuss reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to r=ehuss with the comment fix.

View changes since this review

@ehuss
Copy link
Contributor

ehuss commented Nov 1, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 1, 2025

📌 Commit c169ea0 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
@Zalathar
Rollup merge of rust-lang#148263 - clubby789:bump-libc, r=ehuss
d192ee1 
Unpin `libc` and `rustix` in `compiler` and `rustbook`

Closes rust-lang#147501
@Zalathar Zalathar mentioned this pull request Nov 1, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#148263 - clubby789:bump-libc, r=ehuss
9d70884 
Unpin `libc` and `rustix` in `compiler` and `rustbook`

Closes rust-lang#147501
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 1, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#148263 - clubby789:bump-libc, r=ehuss
54d0ec9 
Unpin `libc` and `rustix` in `compiler` and `rustbook`

Closes rust-lang#147501
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#148263 - clubby789:bump-libc, r=ehuss
8cc32c3 
Unpin `libc` and `rustix` in `compiler` and `rustbook`

Closes rust-lang#147501
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehuss ehuss ehuss left review comments

Assignees

@ehuss ehuss

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unpin libc and update for FreeBSD/riscv support

5 participants

@clubby789 @rustbot @rust-log-analyzer @ehuss @bors