-
Notifications
You must be signed in to change notification settings - Fork 13.9k
parser/lexer: bump to Unicode 17, use faster unicode-ident #148321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
Replace unicode-xid with unicode-ident which is 6 times faster
|
If the Unicode version changes are intentional, cc @ehuss |
|
@bors try @rust-timer queue (Parsing could be affected too). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
parser/lexer: bump to Unicode 17, use faster unicode-ident
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (988451c): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 2.6%, secondary 3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.971s -> 474.835s (0.18%) |
Hello,
Bump the unicode version used by lexer/parser to 17.0.0 by updating:
unicode-normalizationto 0.1.25unicode-propertiesto 0.1.4unicode-widthto 0.2.2and by replacing
unicode-xidwithunicode-identwhich is also 6 times faster.I think it might be worth to run the benchmarks to double check.
(
unicode-identis already insrc/tools/tidy/src/deps.rs)Thanks!