Do not propogate unnecessary closure constraints. #148329
Open
+70
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
| // NOTE: [] is *not* a valid subset, so we check for that as well. | ||
| if single_region | ||
| || shorter_fr_plus == fr_static // `fr-: 'static` should be propogated | ||
| || self.eval_outlives(fr_minus, shorter_fr_plus) |
There was a problem hiding this comment.
I couldn't find anything else that would give me the behaviour that is intended.
Is there something more correct perhaps?
LorrensP-2158466
changed the title
This comment has been minimized.
This comment has been minimized.
LorrensP-2158466
force-pushed
the
closure-prop
branch
from
440270a to
b1299ee
Compare
|
Some changes occurred in src/tools/cargo cc @ehuss |
This comment has been minimized.
This comment has been minimized.
LorrensP-2158466
force-pushed
the
closure-prop
branch
from
b1299ee to
8c66aab
Compare
|
Excuse me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148289
Fixes case 1 of #104477 (it's the same as #148289)
Should unblock #148187
Instead of propogating every
fr-: shorter_fr+we find, only propogate those that matter to the closure in question. This could otherwise cause valid code to be rejected.r? @lcnr