dangling ptr lint cleanup #148348
Open
dangling ptr lint cleanup #148348
+79
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? Urgau |
Urgau
reviewed
Oct 31, 2025
| .ret_ty = return type is `{$ret_ty}` | ||
| .local_var = local variable `{$local_var_name}` is dropped at the end of the {$fn_kind} | ||
| .created_at = dangling pointer created here | ||
| .note = pointers do not have a lifetime; after returning, the `{$local_var_ty}` will be deallocated at the end of the {$fn_kind} because nothing is referencing it as far as the type system is concerned |
There was a problem hiding this comment.
What is the rational for removing this note/explanation?
| lint_dangling_pointers_from_locals = a dangling pointer will be produced because the local variable `{$local_var_name}` will be dropped | ||
| .ret_ty = return type of the {$fn_kind} is `{$ret_ty}` | ||
| .local_var = `{$local_var_name}` is part the {$fn_kind} and will be dropped at the end of the {$fn_kind} | ||
| lint_dangling_pointers_from_locals = {$fn_kind} returns a dangling pointer to a dropped local variable |
There was a problem hiding this comment.
I can see where this is coming from, but this proposed is less descriptive about the issue. Would it be possible to still mention the name of the local variable?
It is quite useful to be able to quickly see the offending item in the main message, in particular with LSP, where we often don't have the full output of rustc.
Btw, the dangling_pointers_from_temporaries lint use a very similar warning phrasing. If we change this one, we should also change the other one for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the dangling_pointers_from_locals lint.