-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Add LLVM range attributes to slice length parameters #148350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
rustbot has assigned @JonathanBrouwer. Use |
| pub fn len_plus_ten_b(s: &[u32]) -> usize { | ||
| // CHECK: start: | ||
| // CHECK-NOT: add | ||
| // CHECK: %[[R:.+]] = add nuw nsw i{{.+}} %s.1, 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the simplest demonstration of LLVM taking advantage of it. See https://rust.godbolt.org/z/7jxqsaaTx showing that it didn't know nuw/nsw for these things previously.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add LLVM range attributes to slice length parameters
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (398e28a): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.716s -> 474.193s (-0.32%) |
It'll take a bunch more work to do this in layout -- because of cycles in
struct Foo<'a>(&'a Foo<'a>);-- so until we figure out how to do that well, just look for slices specifically and add the proper range for the length.