Skip to content

Conversation

@clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Nov 1, 2025

Extension to #147622 which further reduces the size of the generated code, moving more of it into libcore directly.

This way, the verification code and the unsafe methods are right next to each other can be more easily understood.

Doesn't actually affect the compiled data, just moves around the code.

@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2025

library/core/src/unicode/unicode_data.rs is generated by the src/tools/unicode-table-generator tool.

If you want to modify unicode_data.rs, please modify the tool then regenerate the library source file via ./x run src/tools/unicode-table-generator instead of editing unicode_data.rs manually.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@clarfonthey clarfonthey force-pushed the unicode-data-refactor branch from b3de674 to 8858dcd Compare November 1, 2025 13:09
@rust-log-analyzer

This comment has been minimized.

@clarfonthey clarfonthey force-pushed the unicode-data-refactor branch from 8858dcd to 54790a3 Compare November 1, 2025 13:28
@rust-log-analyzer

This comment has been minimized.

@clarfonthey clarfonthey force-pushed the unicode-data-refactor branch from 54790a3 to 4216557 Compare November 1, 2025 13:43
@rust-log-analyzer

This comment has been minimized.

@clarfonthey clarfonthey force-pushed the unicode-data-refactor branch from 4216557 to 7a40275 Compare November 1, 2025 13:58
@rust-log-analyzer

This comment has been minimized.

@clarfonthey clarfonthey force-pushed the unicode-data-refactor branch from 7a40275 to 687d9a1 Compare November 1, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants