Remove explicit install of eslint inside of tidy's Dockerfile
#148880
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tidy` will already install it (when needed) due to it being in `package.json`
rustbot
added
A-CI
Contributor
Author
|
r? @Kobzol |
rustbot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Nov 12, 2025
Member
|
Less code for same behaviour always makes me very happy. :) |
Member
|
Looks great, and tidy passed, so: @bors r=Kobzol,GuillaumeGomez rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 13, 2025
Rollup of 7 pull requests Successful merges: - #147701 (rustdoc: don't ignore path distance for doc aliases) - #148735 (Fix ICE caused by invalid spans for shrink_file) - #148839 (fix rtsan_nonblocking_async lint closure ICE) - #148846 (add a test for combining RPIT with explicit tail calls) - #148872 (fix: Do not ICE when missing match arm with ill-formed subty is met) - #148880 (Remove explicit install of `eslint` inside of `tidy`'s Dockerfile) - #148883 (bootstrap: dont require cmake if local-rebuild is enabled) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 13, 2025
Rollup merge of #148880 - yotamofek:pr/dockerfile-eslint-install, r=Kobzol,GuillaumeGomez Remove explicit install of `eslint` inside of `tidy`'s Dockerfile `tidy` will already install it (when needed) due to it being in `package.json` With this change, we don't have the version of `eslint` specific in two different places :) (this was added in #141705 , before `tidy` gained the ability to run `npm install`, and is not needed anymore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tidywill already install it (when needed) due to it being inpackage.jsonWith this change, we don't have the version of
eslintspecific in two different places :)(this was added in #141705 , before
tidygained the ability to runnpm install, and is not needed anymore)