Skip to content

Fix typo in comment in rustc_errors #148882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in comment in rustc_errors #148882

wants to merge 1 commit into from
+1 −1

Conversation

@20jasper
Copy link
Contributor

@20jasper 20jasper commented Nov 12, 2025

It seems "CharPose" was a typo since I couldn't find any references to it anywhere else in the codebase

@20jasper
Fix typo in comment in rustc_errors
41e236a 
It seems "CharPose" was a typo since I couldn't find any references to it anywhere else in the codebase
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nnethercote
Copy link
Contributor

nnethercote commented Nov 12, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 12, 2025

📌 Commit 41e236a has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2025
Kivooeo
Kivooeo reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please change this to lowercase

View changes since this review

compiler/rustc_errors/src/lib.rs
) -> usize {
let mut line_count = 0;
// Convert CharPos to Usize, as CharPose is character offset
// Convert `CharPos` to `Usize`, as `CharPos` is character offset
Copy link
Member

@Kivooeo Kivooeo Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Convert `CharPos` to `Usize`, as `CharPos` is character offset
// Convert `CharPos` to `usize`, as `CharPos` is character offset

@Kivooeo
Copy link
Member

Kivooeo commented Nov 12, 2025

@bors r-

sorry for interrupting, but this Usize looks painful to me

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo left review comments

@nnethercote nnethercote nnethercote approved these changes

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@20jasper @rustbot @nnethercote @bors @Kivooeo