Skip to content

Disable rustdoc-test-builder test partially for SGX target. #148901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable rustdoc-test-builder test partially for SGX target. #148901

wants to merge 1 commit into from
+4 −1

Conversation

@sardok
Copy link

@sardok sardok commented Nov 13, 2025

The rustdoc-test-builder test started to fail after #148608 for SGX target. The reason is, sgx binary can not be executed directly so rustdoc fails to execute passed --test-builder binary. This PR simply ignores the success part just like it is ignore for wasm target.

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 13, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu
Copy link
Member

jieyouxu commented Nov 13, 2025

r? rustdoc

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 13, 2025
@rustbot rustbot assigned GuillaumeGomez and unassigned jieyouxu Nov 13, 2025
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 13, 2025

Looks good to me, thanks! r=me once CI pass

@sardok
Copy link
Author

sardok commented Nov 13, 2025

@bors r=@GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Nov 13, 2025

@sardok: 🔑 Insufficient privileges: Not in reviewers

@sardok
Copy link
Author

sardok commented Nov 13, 2025

@bors r=@GuillaumeGomez

This command resulted with; @sardok: 🔑 Insufficient privileges: Not in reviewers.

cc @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 13, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 13, 2025

📌 Commit a40c3e5 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 13, 2025
@GuillaumeGomez
Rollup merge of rust-lang#148901 - sardok:disable_rustdoc_test_builde…
138cd58 
…r_sgx, r=GuillaumeGomez

Disable rustdoc-test-builder test partially for SGX target.

The `rustdoc-test-builder` test started to fail after rust-lang#148608 for SGX target. The reason is, sgx binary can not be executed directly so rustdoc fails to execute passed `--test-builder` binary. This PR simply ignores the success part just like it is ignore for `wasm` target.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 13, 2025
Closed
bors added a commit that referenced this pull request Nov 13, 2025
@bors
Auto merge of #148903 - GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27 
Rollup of 4 pull requests

Successful merges:

 - #148587 (stabilize duration_from_nanos_u128)
 - #148638 (Fix ICE for repr simd on non struct)
 - #148808 (Some resolve cleanups)
 - #148901 (Disable rustdoc-test-builder test partially for SGX target.)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sardok @rustbot @jieyouxu @GuillaumeGomez @bors