Remove rustc_inherit_overflow_checks from position() in slice iterators

[theemathas]

This method implementation can never cause an overflow, since i can never go over the slice's length.

[rustbot]

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[joboet]

True, well spotted!
@bors r+ rollup

[bors]

📌 Commit 8d075ae has been approved by joboet

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8d075ae with merge b6d7ff3...

[bors]

☀️ Test successful - checks-actions
Approved by: joboet
Pushing b6d7ff3 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 42f4793 (parent) -> b6d7ff3 (this PR)

Test differences

Show 8 test diffs

8 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b6d7ff3aa71e48e2901b0900f8b5d98126b537ed --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-apple-various: 4471.9s -> 3090.6s (-30.9%)
2. aarch64-apple: 8240.6s -> 10341.3s (+25.5%)
3. dist-x86_64-apple: 8579.0s -> 7184.6s (-16.3%)
4. pr-check-1: 1490.3s -> 1297.0s (-13.0%)
5. dist-arm-linux-musl: 6369.7s -> 5566.6s (-12.6%)
6. x86_64-gnu-nopt: 8088.2s -> 7277.2s (-10.0%)
7. test-various: 6773.8s -> 6113.4s (-9.7%)
8. aarch64-msvc-1: 7304.0s -> 6640.0s (-9.1%)
9. dist-i586-gnu-i586-i686-musl: 5424.6s -> 4941.5s (-8.9%)
10. dist-sparcv9-solaris: 5456.6s -> 5033.3s (-7.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (b6d7ff3): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Max RSS (memory usage)

Results (primary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.2%	[-3.2%, -3.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.2%	[-3.2%, -3.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.7%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.0%, 0.7%]	4

Bootstrap: 473.087s -> 474.001s (0.19%)
Artifact size: 388.70 MiB -> 388.67 MiB (-0.01%)