Skip to content

Conversation

@theemathas
Copy link
Contributor

Having the same lifetime in two covariant arguments doesn't do anything.

The lifetime was unnecessarilly added in faf0852#diff-3cff50afc88a11e641a6851dd19471a7e6470f05dd0cddaf2271e5cdd9936b73L2125

Having the same lifetime in two covariant arguments doesn't do anything.

The lifetime was unnecessarilly added in rust-lang@faf0852#diff-3cff50afc88a11e641a6851dd19471a7e6470f05dd0cddaf2271e5cdd9936b73L2125
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kivooeo
Copy link
Member

Kivooeo commented Nov 14, 2025

Have you found this with clippy or just randomly saw that?

I just wonder if there any other lifetimes like this

@Kivooeo
Copy link
Member

Kivooeo commented Nov 14, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 14, 2025

📌 Commit cf47879 has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2025
@theemathas
Copy link
Contributor Author

I was just reading the code and randomly saw it.

@bors
Copy link
Collaborator

bors commented Nov 14, 2025

⌛ Testing commit cf47879 with merge 77761f3...

@bors
Copy link
Collaborator

bors commented Nov 15, 2025

☀️ Test successful - checks-actions
Approved by: Kivooeo
Pushing 77761f3 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2025
@bors bors merged commit 77761f3 into rust-lang:main Nov 15, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 15, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b6d7ff3 (parent) -> 77761f3 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 77761f314d7243da0fa3b6ca214eeecd51e956e0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3090.6s -> 3678.8s (+19.0%)
  2. aarch64-apple: 10341.3s -> 8439.8s (-18.4%)
  3. dist-aarch64-apple: 8706.0s -> 7569.2s (-13.1%)
  4. pr-check-1: 1297.0s -> 1458.3s (+12.4%)
  5. arm-android: 5768.2s -> 6373.7s (+10.5%)
  6. x86_64-gnu-llvm-21-1: 3262.5s -> 2955.2s (-9.4%)
  7. dist-i586-gnu-i586-i686-musl: 4941.5s -> 5326.4s (+7.8%)
  8. dist-powerpc64le-linux-gnu: 5735.8s -> 5297.6s (-7.6%)
  9. aarch64-msvc-1: 6640.0s -> 7143.1s (+7.6%)
  10. x86_64-gnu-gcc: 2982.1s -> 2765.4s (-7.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@theemathas theemathas deleted the rm_lifetime branch November 15, 2025 02:53
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (77761f3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-3.1%, -3.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.001s -> 473.638s (-0.08%)
Artifact size: 388.67 MiB -> 388.68 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants