-
Notifications
You must be signed in to change notification settings - Fork 14k
Remove unnecessary lifetime in with_generic_param_rib
#148945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Having the same lifetime in two covariant arguments doesn't do anything. The lifetime was unnecessarilly added in rust-lang@faf0852#diff-3cff50afc88a11e641a6851dd19471a7e6470f05dd0cddaf2271e5cdd9936b73L2125
|
Have you found this with clippy or just randomly saw that? I just wonder if there any other lifetimes like this |
|
@bors r+ rollup |
|
I was just reading the code and randomly saw it. |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b6d7ff3 (parent) -> 77761f3 (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 77761f314d7243da0fa3b6ca214eeecd51e956e0 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (77761f3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.001s -> 473.638s (-0.08%) |
Having the same lifetime in two covariant arguments doesn't do anything.
The lifetime was unnecessarilly added in faf0852#diff-3cff50afc88a11e641a6851dd19471a7e6470f05dd0cddaf2271e5cdd9936b73L2125