Skip to content

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Nov 14, 2025

Same as #147495, just keeping it up-to-date.

Same as 147495, just keeping it up-to-date.
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, r=me when green

View changes since this review

@alexcrichton
Copy link
Member Author

@bors: r=lqd rollup

@bors
Copy link
Collaborator

bors commented Nov 14, 2025

📌 Commit 8043cf3 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2025
bors added a commit that referenced this pull request Nov 15, 2025
Update wasm-component-ld to 0.5.19

Same as #147495, just keeping it up-to-date.
@bors
Copy link
Collaborator

bors commented Nov 15, 2025

⌛ Testing commit 8043cf3 with merge c74d8b7...

@bors
Copy link
Collaborator

bors commented Nov 15, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2025
@jieyouxu
Copy link
Member

The self-hosted runner lost communication with the server.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2025
@jieyouxu jieyouxu assigned lqd and unassigned Mark-Simulacrum Nov 15, 2025
@bors
Copy link
Collaborator

bors commented Nov 15, 2025

⌛ Testing commit 8043cf3 with merge f35a2be...

@bors
Copy link
Collaborator

bors commented Nov 15, 2025

☀️ Test successful - checks-actions
Approved by: lqd
Pushing f35a2be to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 15, 2025
@bors bors merged commit f35a2be into rust-lang:main Nov 15, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 15, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 733108b (parent) -> f35a2be (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f35a2bee641e88742b6de10b25c748ef57475f24 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 8307.2s -> 6956.0s (-16.3%)
  2. dist-aarch64-apple: 7275.1s -> 6207.2s (-14.7%)
  3. aarch64-gnu-llvm-20-1: 3776.0s -> 3327.6s (-11.9%)
  4. x86_64-gnu-tools: 3697.9s -> 3281.5s (-11.3%)
  5. i686-gnu-1: 8337.2s -> 7406.6s (-11.2%)
  6. i686-gnu-2: 6068.5s -> 5405.3s (-10.9%)
  7. pr-check-2: 2563.1s -> 2294.9s (-10.5%)
  8. x86_64-rust-for-linux: 3053.6s -> 2754.0s (-9.8%)
  9. x86_64-gnu-llvm-20-1: 3508.9s -> 3165.4s (-9.8%)
  10. x86_64-gnu-llvm-21-3: 6465.6s -> 5837.1s (-9.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f35a2be): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.9% [-2.9%, -2.9%] 1

Max RSS (memory usage)

Results (primary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 1

Cycles

Results (primary -2.7%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.7% [1.7%, 1.7%] 1
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
-3.3% [-4.1%, -2.7%] 4
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Binary size

Results (primary -1.1%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Bootstrap: 472.272s -> 474.05s (0.38%)
Artifact size: 388.64 MiB -> 388.66 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants