compiletest: Don't apply "emscripten" directives to wasm32-unknown-unknown
#148969
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
Member
Author
|
@bors try jobs=test-various,dist-various-1 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Nov 15, 2025
Don't apply "emscripten" directives to `wasm32-unknown-unknown` try-job: test-various try-job: dist-various-1
Zalathar
changed the title
wasm32-unknown-unknownwasm32-unknown-unknown
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This special case dates all the way back to the original introduction of the
wasm32-unknown-unknowntarget, in #45905.Either it isn't needed, in which case we should remove it, or it is needed, in which case we should fix the directives in any affected tests.
Note that while the intent of this code was presumably to make
//@ ignore-emscriptenalso ignore tests on w32-u-u, it has the unfortunate side-effect of also causing//@ only-emscriptentests to run on w32-u-u, which is potentially very confusing.