-
Notifications
You must be signed in to change notification settings - Fork 14k
Add riscv64 uefi target #149036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add riscv64 uefi target #149036
Conversation
Added riscv64gc-unknown-uefi as a Tier 3 target.
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb These commits modify compiler targets. |
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
| // Return None to use the fallback mechanism in create_wrapper_file | ||
| // Use this fallback specifically for RISC-V 64 UEFI | ||
| return None; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
|
Is there a full coff specification for riscv nowadays or are relocations still not supported on riscv? If the latter then how would you even use this target in the first place? |
Add
riscv64gc-unknown-uefitargetThis PR includes the bare minimum changes currently required to include a
riscv64gc-unknown-uefitarget into the Rust compiler source tree. A few minor changes totally a handful of lines were required outside of the target'starget.rsto get the build process to complete successfully, but these should not impose any challenges to existing targets.One edit was made to the
-unknown-uefi.mdsupported targets Markdown file to mention the existence of a tier 3 target. Since this target will originate as a tier 3 target, it will not be included inrustupfor installation. I am willing to make more changes to the Markdown document in order to document how to build, install, and use this new target. Thank you for your consideration of this pull request!!