Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/tools/compiletest/src/common.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::borrow::Cow;
use std::collections::{BTreeSet, HashMap, HashSet};
use std::iter;
use std::process::Command;
Expand Down Expand Up @@ -1011,6 +1012,13 @@ pub struct TargetCfg {
// target spec).
pub(crate) rustc_abi: Option<String>,

/// ELF is the "default" binary format, so the compiler typically doesn't
/// emit a `"binary-format"` field for ELF targets.
///
/// See `impl ToJson for Target` in `compiler/rustc_target/src/spec/json.rs`.
#[serde(default = "default_binary_format_elf")]
pub(crate) binary_format: Cow<'static, str>,

// Not present in target cfg json output, additional derived information.
#[serde(skip)]
/// Supported target atomic widths: e.g. `8` to `128` or `ptr`. This is derived from the builtin
Expand All @@ -1032,6 +1040,10 @@ fn default_reloc_model() -> String {
"pic".into()
}

fn default_binary_format_elf() -> Cow<'static, str> {
Cow::Borrowed("elf")
}

#[derive(Eq, PartialEq, Clone, Debug, Default, serde::Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum Endian {
Expand Down
6 changes: 1 addition & 5 deletions src/tools/compiletest/src/directives/cfg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,7 @@ fn parse_cfg_name_directive<'a>(

condition! {
name: "elf",
condition: !config.target.contains("windows")
&& !config.target.contains("wasm")
&& !config.target.contains("apple")
&& !config.target.contains("aix")
&& !config.target.contains("uefi"),
condition: target_cfg.binary_format == "elf",
message: "when the target binary format is ELF"
}

Expand Down
23 changes: 23 additions & 0 deletions src/tools/compiletest/src/directives/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,29 @@ fn ignore_coverage() {
assert!(check_ignore(&config, "//@ ignore-coverage-run"));
}

#[test]
fn only_ignore_elf() {
let cases = &[
("aarch64-apple-darwin", false),
("aarch64-unknown-linux-gnu", true),
("powerpc64-ibm-aix", false),
("wasm32-unknown-unknown", false),
("wasm32-wasip1", false),
("x86_64-apple-darwin", false),
("x86_64-pc-windows-msvc", false),
("x86_64-unknown-freebsd", true),
("x86_64-unknown-illumos", true),
("x86_64-unknown-linux-gnu", true),
("x86_64-unknown-none", true),
("x86_64-unknown-uefi", false),
];
for &(target, is_elf) in cases {
let config = &cfg().target(target).build();
assert_eq!(is_elf, check_ignore(config, "//@ ignore-elf"), "`//@ ignore-elf` for {target}");
assert_eq!(is_elf, !check_ignore(config, "//@ only-elf"), "`//@ only-elf` for {target}");
}
}

#[test]
fn threads_support() {
let threads = [
Expand Down
Loading