Skip to content

fix the fragment_in_dst_padding_gets_overwritten test on s390x #149056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix the fragment_in_dst_padding_gets_overwritten test on s390x #149056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/ui/consts/const-eval/ptr_fragments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ const _PARTIAL_OVERWRITE: () = {
};

#[allow(dead_code)]
#[cfg(not(target_arch = "s390x"))]
Copy link
Member

@RalfJung RalfJung Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg(not(target_arch = "s390x"))]
#[cfg(not(target_arch = "s390x"))] // u128 is less aligned on s390x, removing the padding

fn fragment_in_dst_padding_gets_overwritten() {
#[repr(C)]
struct Pair {
Expand Down
Loading