FCW Lint when using an ambiguously glob imported trait #149058
+247
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
petrochenkov
added
S-waiting-on-author
petrochenkov
added
S-waiting-on-author
LorrensP-2158466
changed the title
LorrensP-2158466
changed the title
Contributor
Author
|
Addressed your comments and updated pr title and description. @rustbot ready |
rustbot
added
S-waiting-on-review
Comment on lines
+735
to
+740
| self.tcx.node_lint(AMBIGUOUS_TRAIT_GLOB_IMPORTS, segment.hir_id, |diag| { | ||
| diag.primary_message(format!("Use of ambiguously glob imported trait `{trait_name}`")) | ||
| .span(segment.ident.span) | ||
| .span_label(import_span, format!("`{trait_name}`imported ambiguously here")) | ||
| .help(format!("Import `{trait_name}` explicitly")); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Is it possible to add some kind of suggestion like:
Consider importing `{trait_name}` directly:
+ use m1::{trait_name};
| //~| WARNING: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| } | ||
|
|
||
| fn main() {} |
Contributor
There was a problem hiding this comment.
Could you copy all the tests from #148946 as well?
| pub struct TraitCandidate { | ||
| pub def_id: DefId, | ||
| pub import_ids: SmallVec<[LocalDefId; 1]>, | ||
| // FIXME: explain why this is needed for now. |
Contributor
There was a problem hiding this comment.
The FIXME still needs to be addressed.
| pick: &probe::Pick<'_>, | ||
| segment: &hir::PathSegment<'tcx>, | ||
| ) { | ||
| if let probe::PickKind::TraitPick(true) = pick.kind { |
Contributor
There was a problem hiding this comment.
Suggested change
| if let probe::PickKind::TraitPick(true) = pick.kind { | |
| if pick.kind != probe::PickKind::TraitPick(true) { return true } |
petrochenkov
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #147992.
Report a lint when using an ambiguously glob import trait, this is a FCW because this should not be allowed.
r? @petrochenkov