Skip to content

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Nov 19, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

ZuseZ4 and others added 18 commits October 28, 2025 00:47
819247f changed <str as Debug>::fmt such that it does not escape single
quotes, but neglected to apply the same choice to OsString. This commit
does that.
Return `NonZero<u32>` instead of `u32`.
recommend using a HashMap if a HashSet's second generic parameter doesn't implement BuildHasher

closes rust-lang#147147

~The suggestion span is wrong, but I'm not sure how to find the right one.~ fixed

I'm relatively new to the diagnostics ecosystem, so I'm not sure if `span_help` is the right choice. `span_suggestion_*` might be better, but the output from `x test` looks weird in that case.
Add check if span is from macro expansion

The same thing I did in rust-lang#147416, actually the same bug but in another place, I'm not really sure how this method is good for fixing such ICEs, but, it does work and not conflicting with any existing tests, so I guess, it's fine

Fixes rust-lang#147408

r? compiler
…adsmtm

Make SIMD intrinsics available in `const`-contexts

successor to rust-lang#146568, this PR actually makes the SIMD intrinsics `const`, and modifies the tests to test the const-eval implementations

r? `@tgross35` ig (although feel free to reassign, this is not anything targeted really)
…li-obk

Start documenting autodiff activities

Some initial documentation of the autodiff macros and usage examples
…bit-width, r=scottmcm

feat: Add `bit_width` for unsigned `NonZero<T>`

- Tracking issue: rust-lang#142326

This pull request adds a method to the unsigned `NonZero<T>` that return the minimum number of bits required to represent a value.

This can be achieved by using the `get` method and the methods added in rust-lang#142328, but I think adding the `NonZero::bit_width` method is useful because it accomplishes the same thing a little more succinctly.
Match <OsString as Debug>::fmt to that of str

Fixes rust-lang#114583.
… r=chenyukang

autodiff: update formating, improve examples for the unstable-book

r? compiler
@rustbot rustbot added F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 19, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Nov 19, 2025

📌 Commit fd88e61 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025
@bors
Copy link
Collaborator

bors commented Nov 19, 2025

⌛ Testing commit fd88e61 with merge 140044c...

@bors
Copy link
Collaborator

bors commented Nov 19, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 140044c to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 19, 2025
@bors bors merged commit 140044c into rust-lang:main Nov 19, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 19, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#147171 recommend using a HashMap if a HashSet's second generic par… 7a75fb021b6eef9391719f37928c4ea4acadb00e (link)
#147421 Add check if span is from macro expansion c2c8315455ae96adbd98ce0751c295d0a9dcf10e (link)
#147521 Make SIMD intrinsics available in const-contexts b759fb0827ffa131f4ad97cf2e5dab3c2c4bdd07 (link)
#148201 Start documenting autodiff activities 6a5b6cc962123b9483f5b49207c363a424f3f9a1 (link)
#148797 feat: Add bit_width for unsigned NonZero<T> 0da935011855a0284e9a29f2c0194fc86181d491 (link)
#148798 Match ::fmt to that of str 0457dad57e4f8b380157d5324b82a6dbb660146a (link)
#149082 autodiff: update formating, improve examples for the unstab… 6bd972a0444ad5444e00b027d713504087065ff3 (link)

previous master: a591113c0a

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a591113 (parent) -> 140044c (this PR)

Test differences

Show 412 test diffs

Stage 1

  • nonzero::test_nonzero_bit_width: [missing] -> pass (J0)
  • [ui] tests/ui/hashmap/hashset_generics.rs: [missing] -> pass (J3)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147408.rs: [missing] -> pass (J3)
  • ffi::os_str::tests::debug: [missing] -> pass (J4)

Stage 2

  • [ui] tests/ui/hashmap/hashset_generics.rs: [missing] -> pass (J1)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147408.rs: [missing] -> pass (J1)
  • ffi::os_str::tests::debug: [missing] -> pass (J2)
  • nonzero::test_nonzero_bit_width: [missing] -> pass (J2)

Additionally, 404 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 140044cffad5ff8bad8d4a5d2d936bd1ed578db2 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-llvm-20: 2517.3s -> 3170.9s (+26.0%)
  2. aarch64-gnu-llvm-20-2: 2122.8s -> 2586.4s (+21.8%)
  3. dist-apple-various: 3834.0s -> 3063.4s (-20.1%)
  4. x86_64-rust-for-linux: 2633.8s -> 3086.9s (+17.2%)
  5. aarch64-apple: 7545.2s -> 8794.4s (+16.6%)
  6. dist-aarch64-apple: 6556.0s -> 7286.3s (+11.1%)
  7. x86_64-msvc-2: 6623.3s -> 7354.4s (+11.0%)
  8. x86_64-gnu-miri: 4374.9s -> 4852.9s (+10.9%)
  9. x86_64-gnu-tools: 3377.4s -> 3744.4s (+10.9%)
  10. i686-gnu-2: 5500.6s -> 6041.6s (+9.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-autodiff `#![feature(autodiff)]` merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants