-
Notifications
You must be signed in to change notification settings - Fork 14k
fs: Run file lock tests on all platforms that support it #149111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The list of platforms for which file locks are tested is smaller than the list of platforms that support it. Synchronize these here. Link: https://github.com/rust-lang/rust/blob/07bdbaedc63094281483c40a88a1a8f2f8ffadc5/library/std/src/sys/fs/unix.rs#L1291-L1308
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
This comment was marked as outdated.
This comment was marked as outdated.
|
Sorry bors3 @bors2 try jobs=arm-android,test-various |
This comment has been minimized.
This comment has been minimized.
fs: Run file lock tests on all platforms that support it try-job: arm-android try-job: test-various
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 534bfac failed: CI. Failed jobs:
|
Rather than skipping the tests, make sure that they fail. This ensures that if file locking support is added for more platforms in the future, the tests don't wind up quietly skipped.
b824299 to
cea9dd8
Compare
|
@bors2 try jobs=arm-android,test-various |
fs: Run file lock tests on all platforms that support it try-job: arm-android try-job: test-various
This comment has been minimized.
This comment has been minimized.
|
FYI, you no longer need to call bors2 because |
There are a number of platforms that support file locking but aren't getting tested. Synchronize the list and mark the tests
should_panicotherwise, to make sure they get updated if more platforms add locking support.The supported platform list comes from
rust/library/std/src/sys/fs/unix.rs
Lines 1291 to 1308 in 07bdbae