Skip to content

Conversation

@maurer
Copy link
Contributor

@maurer maurer commented Nov 19, 2025

Sync PR to support #148951 generated via josh-proxy

folkertdev and others added 29 commits October 27, 2025 00:28
Forward `TEST_SAMPLE_INTRINSICS_PERCENTAGE`
Add intrinsics for the new AMX target features
This updates the rust-version file to 8401398.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 8401398
Filtered ref: f9e99a8e85fa360f0e820dc75d46cb4583b4300d
Upstream diff: rust-lang/rust@73e6c9e...8401398

This merge was created using https://github.com/rust-lang/josh-sync.
previously the output would just always be all zeroes
Use generic SIMD masked load/stores for avx512 masked load/stores
Use SIMD intrinsics for vector shifts
ARM has withdrawn FEAT_TME
https://developer.arm.com/documentation/102105/lb-05/

LLVM has also dropped support for enabling the feature.
correct some `#[simd_test]` attributes
aarch64: Remove withdrawn FEAT_TME
…dness

correct signedness of pmadd arguments
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

⚠️ Warning ⚠️

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 19, 2025
@folkertdev
Copy link
Contributor

You'll likely need to sync the other way first for this to work smoothly.

@rust-log-analyzer

This comment has been minimized.

@maurer
Copy link
Contributor Author

maurer commented Nov 19, 2025

Ah, OK. I'll try doing a pull first before the push then. New to the josh tool.

@folkertdev
Copy link
Contributor

Also you'll need to enable the avx10_target_feature feature over here (in a separate commit):

#![feature(x86_amx_intrinsics)]

@folkertdev
Copy link
Contributor

Hmm I'm getting

> rustc-josh-sync pull
Updating/installing josh-proxy binary...
josh up and running
previous upstream base: 8401398e1f14a24670ee1a3203713dc2f0f8b3a8
new upstream base: 07bdbaedc63094281483c40a88a1a8f2f8ffadc5
original local HEAD: 50134e10cbd2f81a068259d7796aff2471aae7c1
incoming ref: b477f55437c0afb0690197326bd65e6cba95521f
Merge made by the 'ort' strategy.
Only empty changes were pulled. Rolling back.
Reverting HEAD to 50134e10cbd2f81a068259d7796aff2471aae7c1
Nothing to pull

did you perform the push from the latest stdarch/main commit (we switched branch names)?

@maurer
Copy link
Contributor Author

maurer commented Nov 19, 2025

I ran (with HEAD at upstream/main)

git push "http://localhost:40960/maurer/rust.git:/library/stdarch.git" "HEAD:refs/heads/remove-tme-josh"

because rustc-josh-sync push reliably gives me

Error: cannot perform push

Caused by:
    Command `cd "/usr/local/google/home/mmaurer/github/stdarch" && "git" "push" "http://localhost:42042/maurer/rust.git:/library/stdarch.git" "HEAD:remove-tme-josh7"` failed with exit code Some(1). STDOUT:
    
    STDERR:
    error: The destination you provided is not a full refname (i.e.,
    starting with "refs/"). We tried to guess what you meant by:
    
    - Looking for a ref that matches 'remove-tme-josh7' on the remote side.
    - Checking if the <src> being pushed ('HEAD')
      is a ref in "refs/{heads,tags}/". If so we add a corresponding
      refs/{heads,tags}/ prefix on the remote side.
    
    Neither worked, so we gave up. You must fully qualify the ref.
    hint: The <src> part of the refspec is a commit object.
    hint: Did you mean to create a new branch by pushing to
    hint: 'HEAD:refs/heads/remove-tme-josh7'?
    error: failed to push some refs to 'http://localhost:42042/maurer/rust.git:/library/stdarch.git'

@folkertdev
Copy link
Contributor

I propose we try to merge #149118 instead so we don't need to deal with the merge commits here

@maurer
Copy link
Contributor Author

maurer commented Nov 19, 2025

Great, I'll rebase on top of that instead

@folkertdev
Copy link
Contributor

and cc @Kobzol, hopefully we can make the Josh process smoother than this? I remember getting this error (it's in our Zulip conversion) but it apparently disappeared when I synchronized everything.

The fix may be your equivealent of specifying the path to the rust repo explicitly, e.g. RUSTC_GIT=/path/to/rust rustc-josh-sync push ...

@maurer
Copy link
Contributor Author

maurer commented Nov 19, 2025

Closed in favor of #149118

@maurer maurer closed this Nov 19, 2025
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2025
@maurer
Copy link
Contributor Author

maurer commented Nov 19, 2025

The fix may be your equivealent of specifying the path to the rust repo explicitly, e.g. RUSTC_GIT=/path/to/rust rustc-josh-sync push ...

I tried the command with and without a reference rustc checkout, to the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-merge-commits PR has merge commits, merge with caution. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants