Skip to content

Implement coercions between &pin (mut|const) T and &(mut) T when T: Unpin #149130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement coercions between &pin (mut|const) T and &(mut) T when T: Unpin #149130

wants to merge 1 commit into from
+749 −91

Conversation

@frank-king
Copy link
Contributor

@frank-king frank-king commented Nov 20, 2025 •
edited
Loading

This allows the following (mutual) coercions when T: Unpin:

  • &T <-> Pin<&T>
  • &mut T <-> Pin<&mut T>
  • &mut T -> Pin<&T>
  • Pin<&mut T> -> &T

Part of Pin Ergonomics.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Nov 20, 2025
@frank-king frank-king marked this pull request as ready for review November 20, 2025 11:57
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2025

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in exhaustiveness checking

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frank-king @rust-log-analyzer @rustbot @nnethercote