Fix unused_assignments false positives from macros #149147
Open
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
cjgillot
reviewed
Nov 21, 2025
Comment on lines
76
to
78
| if tcx.def_span(parent).from_expansion() | ||
| && let Some(macro_def_id) = tcx.def_span(parent).ctxt().outer_expn_data().macro_def_id | ||
| && !macro_def_id.is_local() |
Contributor
There was a problem hiding this comment.
Why parent and not def_id?
Should this use tcx.def_span(parent).in_external_macro(tcx.sess.source_map())?
Member
Author
There was a problem hiding this comment.
use def_id will remove the warning for this testcase:
https://github.com/chenyukang/rust/blob/f943606503b142b24edb2b20f77f1eb737fb9ed2/tests/ui/proc-macro/attributes-included.rs#L17
yeah, tcx.def_span(parent).in_external_macro(tcx.sess.source_map()) is simpler.
chenyukang
force-pushed
the
yukang-fix-unused_assignments-macro-gen-147648
branch
from
0f7c6a0 to
c21d817
Compare
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang-fix-unused_assignments-macro-gen-147648
branch
from
c21d817 to
f943606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147648