Skip to content

Conversation

@yotamofek
Copy link
Contributor

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 20, 2025
@yotamofek
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-bors bot added a commit that referenced this pull request Nov 20, 2025
…ups, r=<try>

[WIP] [rustdoc] misc search index cleanups
@rust-bors
Copy link

rust-bors bot commented Nov 20, 2025

⌛ Trying commit 4f6d5e0 with merge 66074cd

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/19541816993

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 20, 2025
@rust-log-analyzer

This comment has been minimized.

@yotamofek
Copy link
Contributor Author

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Nov 20, 2025

Try build cancelled. Cancelled workflows:

@rust-log-analyzer

This comment has been minimized.

@yotamofek yotamofek force-pushed the wip/rustdoc/search_index/misc-cleanups branch from 0ff93fe to a718cbc Compare November 20, 2025 18:06
@yotamofek
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

This pull request is already queued and waiting for a try build to finish.

@rust-bors
Copy link

rust-bors bot commented Nov 20, 2025

⌛ Trying commit a718cbc with merge 0c69ac1

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/19549366451

rust-bors bot added a commit that referenced this pull request Nov 20, 2025
…ups, r=<try>

[WIP] [rustdoc] misc search index cleanups
@yotamofek
Copy link
Contributor Author

yotamofek commented Nov 20, 2025

This pull request is already queued and waiting for a try build to finish.

Hey @Kobzol , just wanted to make sure.. this is a bug, right?

edit: I mean, seems everything is working fine, but I don't think bors should have posted this comment

@Kobzol
Copy link
Member

Kobzol commented Nov 20, 2025

Bors didn't post it, rust-timer did :) It's not a bug, it's an error message. You have already queued this PR before (#149149 (comment)), and then requeued it before the perf. run was finished, so the bot was just letting you know that the second rust-timer queue command was unnecessary. The PR stays queued until the benchmark is done, even if some try builds fail in the meantime.

@yotamofek
Copy link
Contributor Author

Ahhh makes sense, thanks for taking the time to explain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants