-
Notifications
You must be signed in to change notification settings - Fork 14k
Ensure type is monomorphic enough before evaluating size_of / align_of. #149152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Thanks, I also just arrived to pretty much the same diff and was about to push it 😂 I confirmed that the case in #149081 being related to debug assertions is because the pointer deference was triggering an alignment check (and causing evaluation of |
This comment has been minimized.
This comment has been minimized.
|
Oh, fun, that failure is in this doctest: I was going to say the code here made sense to me, since it's what I think oli had suggested, but it seems the rabbit hole just keeps getting deeper... |
c78e411 to
72fee14
Compare
|
I also included UI test changes for overview purposes, but this doesn't look like something we would like to land. |
|
Ah the future incompatibility lint 😕 I guess we need a weaker check for now. Maybe we can just reject alias types for now? Or maybe we make the layout logic itself return TooGeneric instead of failing with an error? |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Helps with #149081.
r? oli-obk