Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Nov 20, 2025

This is another step toward unspecializing Copy.

See also #135634 and rust-lang/hashbrown#662

r? @Amanieu
cc @joboet

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 20, 2025
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 20, 2025
@cuviper
Copy link
Member Author

cuviper commented Nov 20, 2025

Side note: I would also like to upgrade the hashbrown dependency of the compiler, along with indexmap v2.12.1 using its new bucket API, but we can't do that until TrivialClone is in stage0 (beta).

@rust-log-analyzer

This comment has been minimized.

@cuviper
Copy link
Member Author

cuviper commented Nov 20, 2025

Oh, it's more tangled than I realized, because the compiler's hashbrown/nightly still needs to compile in later stages as well. So we can't fully remove the Copy specialization until TrivialClone is in stage0 and we upgrade them all.

So I'll drop that commit here.

@cuviper cuviper force-pushed the library-hashbrown-0.16.1 branch from eb5fdd9 to 3a56d49 Compare November 20, 2025 19:38
@cuviper cuviper changed the title library: upgrade to hashbrown v0.16.1, finishing Copy unspecialization library: upgrade to hashbrown v0.16.1 Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants