Skip to content

Conversation

@EXONER4TED
Copy link

@EXONER4TED EXONER4TED commented Nov 21, 2025

In light of recent unwrap()'s, wanted to make a PR that makes it more clear to newcomers how dangerous unwrap() can be 😉 https://blog.cloudflare.com/18-november-2025-outage/

"unwrap() is like opening an envelope and if it's an error, it's a pipe bomb instead" 💥

A newcomer to the language might think unwrap() is potentially harmless in name...

// all in good jest, feel free to delete this PR - but maybe unwrap() could be clearer? Thoughts?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@ChrisDenton
Copy link
Member

This was already being discussed on the internals forum so any conversation should be had there. If/when there's some consensus on adding a new method is reached, an API Change Proposal should be created prior to making a PR.

So I'm closing this until an ACP is accepted. Though from the current discussion, it's not looking likely.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants