Skip to content

Conversation

@lolbinarycat
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2025
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 21, 2025
@GuillaumeGomez
Copy link
Member

Arf, more work for my rustdoc attribute conversion (you can see it here). T_T

Thanks in any case for the improvement! r=me once CI pass

@rust-log-analyzer

This comment has been minimized.

@lolbinarycat lolbinarycat force-pushed the rustdoc-bad-render-attr branch from 827f24c to 39b7b91 Compare November 21, 2025 21:49
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
fmt check
fmt: checked 6559 files
tidy check
tidy [rustdoc_json (src)]: `rustdoc-json-types` modified, checking format version
tidy [fluent_period (compiler)]: /checkout/compiler/rustc_passes/messages.ftl:106: message `passes_doc_attr_expects_no_value` ends in a period
tidy [fluent_period (compiler)]: /checkout/compiler/rustc_passes/messages.ftl:110: message `passes_doc_attr_expects_string` ends in a period
tidy [fluent_alphabetical (compiler)]: /checkout/compiler/rustc_passes/messages.ftl: message `passes_doc_attr_expects_string` appears before `passes_doc_alias_bad_char`, but is alphabetically later than it. Run `./x.py test tidy --bless` to sort the file correctly
tidy [fluent_period (compiler)]: FAIL
tidy [fluent_alphabetical (compiler)]: FAIL
tidy: Skipping binary file check, read-only filesystem
tidy: The following checks failed: fluent_alphabetical (compiler), fluent_period (compiler)
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Command `/checkout/obj/build/aarch64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/aarch64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 yarn` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1594:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1285:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:54
  local time: Fri Nov 21 21:57:02 UTC 2025
  network time: Fri, 21 Nov 2025 21:57:03 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdoc does not warn about misuse of html render option attributes

4 participants