Skip to content

Conversation

@bstrie
Copy link
Contributor

@bstrie bstrie commented Nov 23, 2025

Long-overdue successor to #80958

Closes #68490

@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2025

compiler-builtins is developed in its own repository. If possible, consider making this change to rust-lang/compiler-builtins instead.

cc @tgross35

@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2025
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@bstrie
Copy link
Contributor Author

bstrie commented Nov 23, 2025

I'm unclear about the order of operations when it comes to updating compiler-builtins (which only requires a single-line change). I'll submit a PR there to make the change, but what needs to be done on the rust-lang/rust side?

@rust-log-analyzer

This comment has been minimized.

@bstrie
Copy link
Contributor Author

bstrie commented Nov 23, 2025

Actually, now I'm even more confused, because I can't actually find the equivalent line in the upstream compiler-builtins.

@bstrie bstrie force-pushed the finally_deprecate_num_consts_mods branch from d5bf725 to 4beceab Compare November 23, 2025 22:16
@rustbot rustbot added the A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) label Nov 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@rust-log-analyzer
Copy link
Collaborator

The job pr-check-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] toml test:false 0.615
error: use of deprecated constant `std::usize::MAX`: replaced by the `MAX` associated constant on this type
   --> src/tools/rustfmt/src/vertical.rs:201:36
    |
201 |         .fold_ok((0, ::std::usize::MAX), |(max_len, min_len), len| {
    |                                    ^^^
    |
    = note: `-D deprecated` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(deprecated)]`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issue for RFC 2700: numeric constants as associated consts

4 participants