-
Notifications
You must be signed in to change notification settings - Fork 14k
miri: use tikv-jemalloc-sys from sysroot
#149252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2486,7 +2486,6 @@ dependencies = [ | |
| "serde_json", | ||
| "smallvec", | ||
| "tempfile", | ||
| "tikv-jemalloc-sys", | ||
| "ui_test", | ||
| ] | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,9 +21,13 @@ extern crate rustc_session; | |
| extern crate rustc_span; | ||
|
|
||
| /// See docs in https://github.com/rust-lang/rust/blob/HEAD/compiler/rustc/src/main.rs | ||
| /// and https://github.com/rust-lang/rust/pull/146627 for why we need this `use` statement. | ||
| #[cfg(any(target_os = "linux", target_os = "macos"))] | ||
| use tikv_jemalloc_sys as _; | ||
| /// and https://github.com/rust-lang/rust/pull/146627 for why we need this. | ||
| /// | ||
| /// FIXME(madsmtm): This is loaded from the sysroot that was built with the other `rustc` crates | ||
| /// above, instead of via Cargo as you'd normally do. This is currently needed for LTO due to | ||
| /// https://github.com/rust-lang/cc-rs/issues/1613. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also saves the time for building jemalloc again so that seems nice 🤷
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. True, though that's also the case for a bunch of other common dependencies like
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tikv-jemalloc has a build script building C dependencies, making it super slow for check builds. That makes it a more worthwhile goal for this than pure Rust crates. Also the allocator is a global singleton after all so using exactly the rustc setup IMO makes a lot of sense. |
||
| #[cfg(feature = "jemalloc")] | ||
| extern crate tikv_jemalloc_sys as _; | ||
|
|
||
| mod log; | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.