Skip to content

Conversation

@davidtwco
Copy link
Member

@davidtwco davidtwco commented Nov 24, 2025

Fixes #138261

Adds a namespace for global_asm with a lowercase letter which is reserved for implementation-internal disambiguation:

Lowercase letters are reserved for implementation-internal disambiguation categories (and demanglers should never show them)

As a implementation-internal disambiguation category, the demangler implementations shouldn't need updated (i.e. if this were an uppercase letter, then our mangle-then-demangle checks would fail because the demangler would expect to have explicit handling). 'a' is chosen arbitrarily, for asm, but I can change it to something else if preferred.

#[rustc_symbol_name] only looks at top-level items, and would need a bunch of changes to be able to check the symbol for foo::{constant}::{closure} in the global_asm in this test, so for now the test just checks this compiles.

The alternative to this would be to prohibit declaration of items in the operand of a global_asm, which is a breaking change.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, I also thinks that 'a' is fine

r=me when ci is green

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: coverage: symbol_names: unexpected DefPathData: GlobalAsm

4 participants